Re: [PATCH v2 3/4] arm64: dts: qcom: sm8550-mtp: add orientation gpio

To: Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sm8550-mtp: add orientation gpio
From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Date: Mon, 2 Oct 2023 12:27:59 +0200
Cc: linux-arm-msm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx
In-reply-to: <20231002-topic-sm8550-upstream-type-c-orientation-v2-3-125410d3ff95@linaro.org>
References: <20231002-topic-sm8550-upstream-type-c-orientation-v2-0-125410d3ff95@linaro.org> <20231002-topic-sm8550-upstream-type-c-orientation-v2-3-125410d3ff95@linaro.org>
User-agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1



On 10/2/23 12:20, Neil Armstrong wrote:

Specify orientation GPIO in the PMIC GLINK node.

You should answer "why", not "what"


Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
---

With that fixed:

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad

References:
- [PATCH v2 0/4] arm64: qcom: sm8550: retrieve USB-C port orientation from gpio
  - From: Neil Armstrong
- [PATCH v2 3/4] arm64: dts: qcom: sm8550-mtp: add orientation gpio
  - From: Neil Armstrong