Hi Neil, kernel test robot noticed the following build errors: [auto build test ERROR on 6465e260f48790807eef06b583b38ca9789b6072] url: https://github.com/intel-lab-lkp/linux/commits/Neil-Armstrong/dt-bindings-input-document-Goodix-Berlin-Touchscreen-IC/20231002-145648 base: 6465e260f48790807eef06b583b38ca9789b6072 patch link: https://lore.kernel.org/r/20231002-topic-goodix-berlin-upstream-initial-v7-3-792fb91f5e88%40linaro.org patch subject: [PATCH v7 3/4] Input: goodix-berlin - add I2C support for Goodix Berlin Touchscreen IC config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20231002/202310021730.epucKAC1-lkp@xxxxxxxxx/config) compiler: nios2-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231002/202310021730.epucKAC1-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310021730.epucKAC1-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): drivers/input/touchscreen/goodix_berlin_core.c: In function 'goodix_berlin_checksum_valid': >> drivers/input/touchscreen/goodix_berlin_core.c:50:16: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration] 50 | return FIELD_GET(GOODIX_BERLIN_COOR_DATA_CHECKSUM_MASK, cal_checksum) == r_checksum; | ^~~~~~~~~ drivers/input/touchscreen/goodix_berlin_core.c: In function 'goodix_berlin_get_ic_info': >> drivers/input/touchscreen/goodix_berlin_core.c:284:1: warning: the frame size of 1140 bytes is larger than 1024 bytes [-Wframe-larger-than=] 284 | } | ^ cc1: some warnings being treated as errors vim +/FIELD_GET +50 drivers/input/touchscreen/goodix_berlin_core.c 3fd649a6bbd95d Neil Armstrong 2023-10-02 15 3fd649a6bbd95d Neil Armstrong 2023-10-02 16 /* 3fd649a6bbd95d Neil Armstrong 2023-10-02 17 * Goodix "Berlin" Touchscreen ID driver 3fd649a6bbd95d Neil Armstrong 2023-10-02 18 * 3fd649a6bbd95d Neil Armstrong 2023-10-02 19 * This driver is distinct from goodix.c since hardware interface 3fd649a6bbd95d Neil Armstrong 2023-10-02 20 * is different enough to require a new driver. 3fd649a6bbd95d Neil Armstrong 2023-10-02 21 * None of the register address or data structure are close enough 3fd649a6bbd95d Neil Armstrong 2023-10-02 22 * to the previous generations. 3fd649a6bbd95d Neil Armstrong 2023-10-02 23 * 3fd649a6bbd95d Neil Armstrong 2023-10-02 24 * Currently only handles Multitouch events with already 3fd649a6bbd95d Neil Armstrong 2023-10-02 25 * programmed firmware and "config" for "Revision D" Berlin IC. 3fd649a6bbd95d Neil Armstrong 2023-10-02 26 * 3fd649a6bbd95d Neil Armstrong 2023-10-02 27 * Support is missing for: 3fd649a6bbd95d Neil Armstrong 2023-10-02 28 * - ESD Management 3fd649a6bbd95d Neil Armstrong 2023-10-02 29 * - Firmware update/flashing 3fd649a6bbd95d Neil Armstrong 2023-10-02 30 * - "Config" update/flashing 3fd649a6bbd95d Neil Armstrong 2023-10-02 31 * - Stylus Events 3fd649a6bbd95d Neil Armstrong 2023-10-02 32 * - Gesture Events 3fd649a6bbd95d Neil Armstrong 2023-10-02 33 * - Support for older revisions (A & B) 3fd649a6bbd95d Neil Armstrong 2023-10-02 34 */ 3fd649a6bbd95d Neil Armstrong 2023-10-02 35 3fd649a6bbd95d Neil Armstrong 2023-10-02 36 static bool goodix_berlin_checksum_valid(const u8 *data, int size) 3fd649a6bbd95d Neil Armstrong 2023-10-02 37 { 3fd649a6bbd95d Neil Armstrong 2023-10-02 38 u32 cal_checksum = 0; 3fd649a6bbd95d Neil Armstrong 2023-10-02 39 u16 r_checksum; 3fd649a6bbd95d Neil Armstrong 2023-10-02 40 u32 i; 3fd649a6bbd95d Neil Armstrong 2023-10-02 41 3fd649a6bbd95d Neil Armstrong 2023-10-02 42 if (size < GOODIX_BERLIN_COOR_DATA_CHECKSUM_SIZE) 3fd649a6bbd95d Neil Armstrong 2023-10-02 43 return false; 3fd649a6bbd95d Neil Armstrong 2023-10-02 44 3fd649a6bbd95d Neil Armstrong 2023-10-02 45 for (i = 0; i < size - GOODIX_BERLIN_COOR_DATA_CHECKSUM_SIZE; i++) 3fd649a6bbd95d Neil Armstrong 2023-10-02 46 cal_checksum += data[i]; 3fd649a6bbd95d Neil Armstrong 2023-10-02 47 3fd649a6bbd95d Neil Armstrong 2023-10-02 48 r_checksum = get_unaligned_le16(&data[i]); 3fd649a6bbd95d Neil Armstrong 2023-10-02 49 3fd649a6bbd95d Neil Armstrong 2023-10-02 @50 return FIELD_GET(GOODIX_BERLIN_COOR_DATA_CHECKSUM_MASK, cal_checksum) == r_checksum; 3fd649a6bbd95d Neil Armstrong 2023-10-02 51 } 3fd649a6bbd95d Neil Armstrong 2023-10-02 52 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
