On 30/09/2023 15:41, Bryan O'Donoghue wrote: > Various of the camcc bindings are repeated serially. Aggregate the > common defintions into one place declaring common required in one place > also. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > --- > .../bindings/clock/qcom,camcc-common.yaml | 44 +++++++++++++++++++ > .../bindings/clock/qcom,camcc-sm8250.yaml | 32 ++------------ > .../bindings/clock/qcom,sc7180-camcc.yaml | 23 ++-------- > .../bindings/clock/qcom,sc7280-camcc.yaml | 23 ++-------- > .../bindings/clock/qcom,sdm845-camcc.yaml | 23 ++-------- > .../bindings/clock/qcom,sm6350-camcc.yaml | 13 ++---- > .../bindings/clock/qcom,sm8450-camcc.yaml | 33 ++------------ > 7 files changed, 67 insertions(+), 124 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml > > diff --git a/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml b/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml > new file mode 100644 > index 000000000000..ce0140985fe7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,camcc-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Camera Clock & Reset Controller common properties > + > +maintainers: > + - Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > + > +description: | > + Qualcomm camera clock control module provides the clocks, resets and power > + domains on Qualcomm SoCs. > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +properties: > + compatible: true Drop, not needed. > + > + clocks: > + minItems: 1 > + maxItems: 4 No real benefit of these in common schema. It's still not precise :/ > + > + clock-names: > + minItems: 1 > + maxItems: 4 The same. > + > + power-domains: > + maxItems: 1 > + description: > + A phandle and PM domain specifier for the MMCX power domain. Not all bindings have it, so again not much benefits to have it in common place. > + > + required-opps: > + maxItems: 1 > + description: > + OPP node describing required MMCX performance point. > + > +required: > + - compatible Drop > + - clocks As well... so this leads us to almost empty common binding. That's why I suggested to use qcom,gcc.yaml. Best regards, Krzysztof
