On Tue, Sep 19, 2023 at 02:42:22PM +0200, Sebastian Reichel wrote: > qcom_battmgr_update_request.battery_id is written to using cpu_to_le32() > and should be of type __le32, just like all other 32bit integer requests > for qcom_battmgr. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202309162149.4owm9iXc-lkp@xxxxxxxxx/ > Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > --- > drivers/power/supply/qcom_battmgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c > index de77df97b3a4..a05fd00711f6 100644 > --- a/drivers/power/supply/qcom_battmgr.c > +++ b/drivers/power/supply/qcom_battmgr.c > @@ -105,7 +105,7 @@ struct qcom_battmgr_property_request { > > struct qcom_battmgr_update_request { > struct pmic_glink_hdr hdr; > - u32 battery_id; > + __le32 battery_id; > }; > > struct qcom_battmgr_charge_time_request { I can confirm that this addresses the corresponding sparse warnings: Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx> I'll send a fix for the remaining warnings... Johan
