On Wed, Sep 27, 2023 at 05:46:02PM +0200, Manivannan Sadhasivam wrote: > Instead of hardcoding the link speed in MBps, let's make use of the > existing PCIE_SPEED2MBS_ENC() macro that does the encoding of the > link speed for us. Also, let's Wrap it with QCOM_PCIE_LINK_SPEED_TO_BW() > macro to do the conversion to ICC speed. In subject, /Make use of/Use/ would make better use of the subject line. Lots of "uses" there :) Above, s/let's//, and also s/make use of/use/. > +#define QCOM_PCIE_LINK_SPEED_TO_BW(speed) \ > + Mbps_to_icc(PCIE_SPEED2MBS_ENC(pcie_link_speed[speed])) It's a shame to have to duplicate this macro in pcie-qcom.c and in pcie-qcom-ep.c, especially since there's nothing qcom-specific in it. Would a macro like this fit in interconnect.h? > - ret = icc_set_bw(pcie_ep->icc_mem, 0, MBps_to_icc(PCIE_GEN1_BW_MBPS)); > + ret = icc_set_bw(pcie_ep->icc_mem, 0, QCOM_PCIE_LINK_SPEED_TO_BW(1)); "1" is not very informative here. Maybe PCIE_SPEED_2_5GT? (I didn't completely verify that this is equivalent.) Bjorn
