On 26.09.2023 18:51, Stephan Gerhold wrote:
> From: "Lin, Meng-Bo" <linmengbo0689@xxxxxxxxxxxxxx>
>
> Enable sound and modem for the Samsung J5 smartphones. The setup is
> similar to most MSM8916 devices, i.e.:
>
> - QDSP6 audio
> - Speaker/earpiece/headphones/microphones via digital/analog codec
> in MSM8916/PM8916
> - WWAN Internet via BAM-DMUX
>
> except:
>
> - There is no secondary microphone, so a different "model" is used to
> differentiate that in the UCM configuration.
> - Samsung-specific audio jack detection (not supported yet)
>
> Co-developed-by: Markuss Broks <markuss.broks@xxxxxxxxx>
> Signed-off-by: Markuss Broks <markuss.broks@xxxxxxxxx>
> Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@xxxxxxxxxxxxxx>
> [Stephan: Add consistent commit message]
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi | 15 +++++++++++++++
> arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts | 4 ++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi
> index fe59be3505fe..2caa820b0c26 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi
> @@ -1,6 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0-only
>
> #include "msm8916-pm8916.dtsi"
> +#include "msm8916-modem-qdsp6.dtsi"
> +
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> @@ -135,6 +137,10 @@ &blsp_uart2 {
> status = "okay";
> };
>
> +&mpss_mem {
> + reg = <0x0 0x86800000 0x0 0x5800000>;
> +};
> +
> &pm8916_resin {
> status = "okay";
> linux,code = <KEY_VOLUMEDOWN>;
> @@ -154,6 +160,15 @@ &sdhc_2 {
> cd-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> };
>
> +&sound {
> + model = "msm8916-1mic";
That's.. vague.. Is that intended?
I also noticed only now that random patches have status
at random places in the property tree.. Removing the disablement
would aid that as well (wink wink)!
Konrad
