Re: [PATCH] soc: qcom: llcc: Handle a second device without data corruption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Sep 26, 2023 at 10:32:29AM +0200, Uwe Kleine-König wrote:
> the check added here is racy. To fix that race a lock would be needed to
> protect drv_data. Alternatively (and cleaner) drv_data could be stored
> using platform_set_drvdata(pdev, ...), but that cannot be done trivially
> because there is a global function (llcc_slice_getd) that needs drv_data
> but has no access to the platform device.
> I don't know what is sensible here, so I just added this 90% fix. If you
> want a more sophisticated solution, please create one yourself and just
> consider my patch a problem report.

if you consider this a fix, the corresponding tag line is:

Fixes: a3134fb09e0b ("drivers: soc: Add LLCC driver")

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | |

Attachment: signature.asc
Description: PGP signature

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux