On Wednesday 07 October 2015 12:27:54 ygardi@xxxxxxxxxxxxxx wrote: > > >> + > >> +/* > >> + * IOCTL opcode for ufs queries has the following opcode after > >> + * SCSI_IOCTL_GET_PCI > >> + */ > >> +#define UFS_IOCTL_QUERY 0x5388 > > > > Use _IOWR() to define that number with the correct argument length > > i'd rather leave it as is, to be compatible with the SCSI_IOCTL > opcodes that are defined in scsi_ioctl.h Do you mean you require this code to work on SunOS? ;-) If not, better use the normal conventions that Linux and BSD have for new ioctls. Note that the 0x53xx ioctl command numbers are also used by include/uapi/linux/cdrom.h, this one would be right in the middle of that. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html