On 10/01, Stephen Boyd wrote: > On 10/01, Rajendra Nayak wrote: > > On 09/24/2015 12:39 AM, Stephen Boyd wrote: > > >+ > > >+ ret = pm_genpd_add_subdomain(&oxili_gdsc.pd, &oxilicx_gdsc.pd); > > > > We'll need pm_genpd_add_subdomain() to be EXPORT_SYMBOL_GPL'ed so > > clk-qcom can be built as a module. > > Good catch! Do we need to call pm_genpd_remove_subdomain() too? Looks like yes. > > > > > It would also be nicer if this parent/child relationship can > > somehow be represented in data (struct gdsc) that gets passed to > > the gdsc driver which then sets it up, instead of individual > > clock drivers doing it. > > Agreed. I'd rather that we do nothing besides register domains > and then let the core code handle hooking up domains and > subdomains. A little closer inspection makes me want to skip this. PM domains can have multiple "master" domains, and pm_genpd_init() is the only API that would be able to do the linking. That API is mostly about initializing things to default values, so it doesn't seem like a good fit. I'll send a v2 with the remove part and the exports. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
