Krzysztof Kozlowski писал(а) 17.09.2023 12:58: > On 16/09/2023 15:57, Nikita Travkin wrote: >> PM8916 (and probably some other similar pmics) have hardware blocks for >> battery monitoring and charging. Add patterns for respecive nodes so the > > typo: respective > Oops, will fix if we get to v2. >> dt for those blocks can be validated properly. >> >> Signed-off-by: Nikita Travkin <nikita@xxxxxxx> >> --- >> Schemas for those devices were added in [1]. > > "Dependency" > You are right, will try to word it better next time. >> >> [1] https://lore.kernel.org/r/20230915-pm8916-bms-lbc-v3-0-f30881e951a0@xxxxxxx >> --- >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> index 9f03436b1cdc..8bcd76748faa 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> @@ -133,9 +133,15 @@ patternProperties: >> type: object >> $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml# >> >> + "^battery@[0-9a-f]+$": >> + type: object >> + oneOf: >> + - $ref: /schemas/power/supply/qcom,pm8916-bms-vm.yaml# > > That's just ref, so no need for oneOf... unless you already think this > will grow with different schemas like the charger below? > Yes, I think some other PMICs have different battery/fuel-gauge blocks too so I'd like to have some room for expansion here. Thanks for the review! Nikita >> + >> "^charger@[0-9a-f]+$": >> type: object >> oneOf: >> + - $ref: /schemas/power/supply/qcom,pm8916-lbc.yaml# >> - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# >> - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# >> - $ref: /schemas/power/supply/qcom,pmi8998-charger.yaml# >> > > Best regards, > Krzysztof
