On Fri, Sep 15, 2023 at 03:51:52PM +0200, Konrad Dybcio wrote: > On 11.09.2023 19:41, Stephan Gerhold wrote: > > The modem firmware size is typically highly device-specific. > > The current size of the mpss_mem region in msm8916.dtsi (0x2b00000) > > only works for some APQ8016 devices without full-featured modem, > > such as the DragonBoard 410c. > > > > The full modem firmware is typically about twice as large (~45 MiB > > -> ~90 MiB) but also varies by a few MiB from device to device. Since > > these devices are quite memory-constrained nowadays it's important to > > minimize the unnecessary memory reservations. > > > > Make it clear that each board needs to specify the necessary mpss_mem > > size by replacing the DB410c-specific size in msm8916.dtsi with a > > simple comment. &mpss_mem is disabled by default so it's fine to leave > > some properties up to the boards if they want to enable it. > > > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > > --- > Any reason not to squash it with one of the earlier patches then? > I'm not strictly opposed but these are really two independent changes. One drops the fixed memory regions and makes the allocation dynamic, in the SoC dtsi. This one moves board-specific information out of the SoC dtsi (to the boards). Thanks, Stephan
