Hi Bjorn, On Wed, Aug 16, 2023 at 11:23 AM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > Several trogdor boards have moved from the older rt5862i to the newer > rt5862s, at least on newer revisions of boards. Let's get rid of the > dts duplication across boards and promote this to a fragment. > > Note: The old boards used to override the "compatible" in the "sound" > node with the exact same thing that was in "sc7180-trogdor.dtsi" > ("google,sc7180-trogdor"). I got rid of that. > > This is validated to produce the same result when taking the dtbs > generated by the kernel build and then doing: > > for dtb in *trogdor*.dtb; do > dtc -I dtb -O dts $dtb -o out/$dtb.dts; > done > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > > .../boot/dts/qcom/sc7180-trogdor-kingoftown.dts | 13 +------------ > .../dts/qcom/sc7180-trogdor-pazquel360.dtsi | 13 +------------ > .../dts/qcom/sc7180-trogdor-rt5682s-sku.dtsi | 17 +++++++++++++++++ > ...180-trogdor-wormdingler-rev1-boe-rt5682s.dts | 13 +------------ > ...180-trogdor-wormdingler-rev1-inx-rt5682s.dts | 13 +------------ > 5 files changed, 21 insertions(+), 48 deletions(-) If you agree, it would be a wonderful time to land this patch now. Please let me know if there is anything outstanding you want me to change. NOTE: if it were me, I'd land _just_ patch #1 in this series (AKA ${SUBJECT} patch) and skip patch #2. I don't mattery a ton either way, but it seemed like Konrad agreed with me that the benefits of patch #2 were questionable and, unless someone loves it, I vote for less churn instead of more churn. :-P -Doug