Krzysztof Kozlowski писал(а) 05.09.2023 12:12:
> On 05/09/2023 07:47, Nikita Travkin wrote:
>> + apr {
>> + compatible = "qcom,apr-v2";
>> + qcom,glink-channels = "apr_audio_svc";
>> + qcom,apr-domain = <APR_DOMAIN_ADSP>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + apr-service@3 {
>
> Except missing tests, few more things to fix
Will rename the services to fit the schema
>
>> + reg = <APR_SVC_ADSP_CORE>;
>> + compatible = "qcom,q6core";
>
> compatible is always the first property.
>
Ack, missed that
>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>> + };
>> +
>> + q6afe: apr-service@4 {
>> + compatible = "qcom,q6afe";
>> + reg = <APR_SVC_AFE>;
>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>> +
>> + q6afedai: dais {
>> + compatible = "qcom,q6afe-dais";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> You do not have any children, so drop these two. I will fix the binding.
>
As you have already pointed out, the children will be in the board.
Will keep the sizes for this and the next one.
Nikita
>> + #sound-dai-cells = <1>;
>> + };
>> +
>> + q6afecc: cc {
>> + compatible = "qcom,q6afe-clocks";
>> + #clock-cells = <2>;
>> + };
>> + };
>> +
>> + q6asm: apr-service@7 {
>> + compatible = "qcom,q6asm";
>> + reg = <APR_SVC_ASM>;
>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>> +
>> + q6asmdai: dais {
>> + compatible = "qcom,q6asm-dais";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> Ditto
>
>> + #sound-dai-cells = <1>;
>> + iommus = <&apps_smmu 0x1001 0x0>;
>> + };
>> + };
>> +
>> + q6adm: apr-service@8 {
>> + compatible = "qcom,q6adm";
>> + reg = <APR_SVC_ADM>;
>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>> +
>> + q6routing: routing {
>> + compatible = "qcom,q6adm-routing";
>> + #sound-dai-cells = <0>;
>> + };
>> + };
>> + };
>
>
> Best regards,
> Krzysztof
