On 28.08.2023 08:48, Jagadeesh Kona wrote: > > > On 8/26/2023 4:17 PM, Konrad Dybcio wrote: >> On 23.08.2023 12:41, Abel Vesa wrote: >>> On 23-08-16 19:56:46, Konrad Dybcio wrote: >>>> On 16.08.2023 16:57, Abel Vesa wrote: >>>>> From: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx> >>>>> >>>>> The current HW_CTRL flag switches the video GDSC to HW control mode as >>>>> part of GDSC enable itself, instead of that use HW_CTRL_TRIGGER flag to >>>>> give consumer drivers more control and switch the GDSC mode as and when >>>>> required. >>>>> >>>>> HW_CTRL_TRIGGER flag allows consumer drivers to switch the video GDSC to >>>>> HW/SW control modes at runtime using dev_pm_genpd_set_hwmode API. >>>>> >>>>> Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx> >>>>> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> >>>>> --- >>>> Do we have any use for the HW_CTRL flag? >>>> >>>> Perhaps it should be renamed to HW_CTRL_ALWAYS? >>>> >>>> Or even better, *if and only if* that is necessary, add a common >>>> property like "always_hw_managed" to the genpd code? >>> >>> The HW_CTRL flag is still needed for the consumers that expect the GDSC >>> to be have the HW control bit set right after it gets enabled. >> Guess the correct question here would be.. Are there any? >> > > Yes, Display GDSC(mdss_gdsc) is required to be controlled always in HW control mode when it is enabled. Oh really? Looking at msm-5.10 techpack, only the SDE RSC driver seems to trigger regulator fast mode (so, enabling gdsc hw_ctrl on downstream). Konrad
