Re: [PATCH 1/7] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible

[Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>]

Hi Krzysztof,

On 8/29/2023 12:51 AM, Krzysztof Kozlowski wrote:
> On 28/08/2023 21:18, Sricharan Ramabadhran wrote:
> > IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
> >
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> > ---
> >   .../bindings/thermal/qcom-tsens.yaml          | 19 +++++++++++++++++++
> >   1 file changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > index 27e9e16e6455..2309bb6dce1b 100644
> > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > @@ -42,6 +42,7 @@ properties:
> >                 - qcom,msm8956-tsens
> >                 - qcom,msm8976-tsens
> >                 - qcom,qcs404-tsens
> > +              - qcom,ipq5018-tsens
>
> This does not look like placed in alphanumeric order.

 ok, will sort.

> >             - const: qcom,tsens-v1
> >   
> >         - description: v2 of TSENS
> > @@ -409,4 +410,22 @@ examples:
> >              #qcom,sensors = <16>;
> >              #thermal-sensor-cells = <1>;
> >       };
> > +
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    // Example 5 (for any IPQ5018 based SoC-s):
>
> No need for new example for a difference in compatible. Drop it.

 ok, will drop it.

Regards,
 Sricharan