On 28.08.2023 11:36, Maulik Shah (mkshah) wrote: > Hi Dmitry, > > This patch may be useful if there was a case where some PDCs don't have version register populated/available, > In all PDC versions, version register is always available but due to reg size not good enough in device tree for SM8150 it failed to read. > > reg size in device node must be expanded if its too small to access all registers and i think > additional check in driver to check if size is good enough would not be of much use. The devicetree change has already been commited and not taking care of this on the driver side would break backwards compatibility with devicetrees without this change. Konrad