On 26/08/2023 16:09, Dmitry Baryshkov wrote: >>> +MODULE_DEVICE_TABLE(of, lpasscc_sm6115_match_table); >> >> Everything here is almost the same as sc8280xp one, so this should be >> added to sc8280xp. You cut some boilerplate and additional driver. > > We have been there. It quickly becomes a nightmare to maintain. > Consider dispcc-sm8250.c Because too much was added. I do not propose to keep all resets here. > > But I agree with you, this code looks too similar. If we expect more > similar lpasscc drivers, which provide no clocks, just several resets, > maybe we can create a common generic wrapper and make resets lists > corresponding driver data? This would also work. Best regards, Krzysztof
