Re: [PATCH v3 11/15] media: qcom: camss: Functionally decompose CSIPHY clock lookups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/08/2023 11:12, Konrad Dybcio wrote:
-			csiphy->rate_set[i] = true;
+		for (k = 0; k < camss->res->csiphy_num; k++) {
+			csiphy->rate_set[i] = csiphy_match_clock_name(clock->name,
+								      "csiphy%d_timer", k);
This entire functions is like.. soooo over-engineered

I'm going to accept your compliment there.


adding something like csiphy_timer_clks and cisphy_clks and stuff
would make this string comparison mess unnecessary

I don't understand your comment.

Having a litany of static comparisons is definitely inferior to a generic helper function.

I'm not sure what you are asking/arguing for here.

---
bod






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux