On Wed, 23 Aug 2023 at 20:12, Adrien Thierry <athierry@xxxxxxxxxx> wrote:
>
> Currently, PCS_USB registers that have their initialization data in a
> pcs_usb_tbl table are never initialized. Fix that.
>
> Fixes: fc64623637da ("phy: qcom-qmp-combo,usb: add support for separate PCS_USB region")
> Signed-off-by: Adrien Thierry <athierry@xxxxxxxxxx>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
> index 466f0a56c82e..ccbe64f7897e 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
> @@ -2233,6 +2233,7 @@ static int qmp_usb_power_on(struct phy *phy)
> void __iomem *tx = qmp->tx;
> void __iomem *rx = qmp->rx;
> void __iomem *pcs = qmp->pcs;
> + void __iomem *pcs_usb = qmp->pcs_usb ?: qmp->pcs;
> void __iomem *status;
> unsigned int val;
> int ret;
> @@ -2255,6 +2256,7 @@ static int qmp_usb_power_on(struct phy *phy)
> }
>
> qmp_usb_configure(pcs, cfg->pcs_tbl, cfg->pcs_tbl_num);
> + qmp_usb_configure(pcs_usb, cfg->pcs_usb_tbl, cfg->pcs_usb_tbl_num);
I think we don't need to fallback to pcs here: if there is a separate
pcs_usb_tbl, we need a separate pcs_usb region. Just pass qmp->pcs_usb
here.
>
> if (cfg->has_pwrdn_delay)
> usleep_range(10, 20);
> --
> 2.41.0
>
--
With best wishes
Dmitry
