Hi Bryan, On Thu, Aug 24, 2023 at 10:15:32AM +0100, Bryan O'Donoghue wrote: > On 23/08/2023 18:12, Adrien Thierry wrote: > > This series attempts at making sure PCS_USB registers are properly > > initialized. Please note I don't have access to the qmp phy datasheet and > > only reasoned from the code, so I appreciate a double check to make sure > > I'm not messing with the registers. > > > > Adrien Thierry (2): > > phy: qcom-qmp-usb: initialize PCS_USB registers > > phy: qcom-qmp-usb: split PCS_USB init table for sc8280xp and sa8775p > > > > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 22 +++++++++++++++++----- > > 1 file changed, 17 insertions(+), 5 deletions(-) > > > > How is this series tested ? What are the before/after results/effects ? > I tested this series on the sa8775p. AFAICT there's no noticeable change before/after the patch series: lsusb and dmesg output are the same. USB is still working properly. I don't know what those PCS_USB registers do exactly on the qmp PHY and I don't have access to docs, so it's hard for me to tell the impact of them being initialized vs not. > --- > bod Best, Adrien
