Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3

To: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>, rfoss@xxxxxxxxxx, todor.too@xxxxxxxxx, agross@xxxxxxxxxx, andersson@xxxxxxxxxx, konrad.dybcio@xxxxxxxxxx, mchehab@xxxxxxxxxx, sakari.ailus@xxxxxxxxxxxxxxx, andrey.konovalov@xxxxxxxxxx
Subject: Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3
From: "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>
Date: Mon, 21 Aug 2023 19:51:59 +0100
Cc: linux-media@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx
In-reply-to: <edd4bf9b-0e1b-883c-1a4d-50f4102c3924@xs4all.nl>
References: <20230814141007.3721197-1-bryan.odonoghue@linaro.org> <20230814141007.3721197-9-bryan.odonoghue@linaro.org> <edd4bf9b-0e1b-883c-1a4d-50f4102c3924@xs4all.nl>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 21/08/2023 10:53, Hans Verkuil wrote:

+		u8 dt_id = vc * 4;


You're right.

dt_id = vc is wrong but so is dt_id = vc * 4.

I'll post a fix for the dt_id as a separate patch.

---
bod

Follow-Ups:
- Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3
  - From: Bryan O'Donoghue

References:
- [PATCH v0 0/9] media: qcom: camss: Bugfix series
  - From: Bryan O'Donoghue
- [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3
  - From: Bryan O'Donoghue
- Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3
  - From: Hans Verkuil