On Sat, 2023-08-05 at 17:41:40 UTC, Manivannan Sadhasivam wrote: > qcom_check_op() function checks for the invalid opcode for the instruction > types. Currently, it just returns -ENOTSUPP for all opcodes of > NAND_OP_CMD_INSTR type due to the use of "||" operator instead of "&&". > Fix it! > > This also fixes the following smatch warning: > > drivers/mtd/nand/raw/qcom_nandc.c:3036 qcom_check_op() warn: was && intended here instead of ||? > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Closes: https://lore.kernel.org/r/202308032022.SnXkKyFs-lkp@xxxxxxxxx/ > Fixes: 89550beb098e ("mtd: rawnand: qcom: Implement exec_op()") > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
