Re: [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>, rfoss@xxxxxxxxxx, todor.too@xxxxxxxxx, agross@xxxxxxxxxx, andersson@xxxxxxxxxx, mchehab@xxxxxxxxxx, hverkuil-cisco@xxxxxxxxx, laurent.pinchart@xxxxxxxxxxxxxxxx, sakari.ailus@xxxxxxxxxxxxxxx, andrey.konovalov@xxxxxxxxxx
Subject: Re: [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources
From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Date: Wed, 16 Aug 2023 19:10:38 +0200
Cc: linux-media@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20230814162907.3878421-4-bryan.odonoghue@linaro.org>
References: <20230814162907.3878421-1-bryan.odonoghue@linaro.org> <20230814162907.3878421-4-bryan.odonoghue@linaro.org>
User-agent: Mozilla Thunderbird

On 14.08.2023 18:28, Bryan O'Donoghue wrote:
> The NULL pointer assignement is a redundant step our compiler will
> initialize unpopulated fields as zero. We check for logical ! later on
> in the code as opposed to NULL anyway.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
Just squash it with patch 2?

Konrad

Follow-Ups:
- Re: [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources
  - From: Bryan O'Donoghue

References:
- [PATCH v1 00/14] media: qcom: camss: Add parameter passing to remove several outstanding bugs
  - From: Bryan O'Donoghue
- [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources
  - From: Bryan O'Donoghue

Prev by Date: Re: [PATCH v3 2/4] firmware: qcom_scm: disable SDI if required
Next by Date: Re: [PATCH v1 02/14] media: qcom: camss: Start to move to module compat matched resources
Previous by thread: [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources
Next by thread: Re: [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]