Hi, On Sun, Aug 6, 2023 at 11:32 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 04/08/2023 11:58, Sheng-Liang Pan wrote: > > Introduce more sc7180-lazor sku and board version configuration, > > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen, > > add new board version 10 for audio codec ALC5682i-VS. > > > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > --- > > > > Changes in v2: > > - add new entry rev9 with Parade bridge chip > > > > .../devicetree/bindings/arm/qcom.yaml | 55 +++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > > index 450f616774e0..dce7b771a280 100644 > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > > @@ -470,6 +470,11 @@ properties: > > - const: google,lazor-rev8 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip (rev9) > > + items: > > + - const: google,lazor-rev9 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook Spin 513 (newest rev) > > items: > > - const: google,lazor > > @@ -491,6 +496,11 @@ properties: > > - const: google,lazor-rev8-sku2 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip with KB Backlight (rev9) > > + items: > > + - const: google,lazor-rev9-sku2 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook Spin 513 with KB Backlight (newest rev) > > items: > > - const: google,lazor-sku2 > > @@ -512,11 +522,26 @@ properties: > > - const: google,lazor-rev8-sku0 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9) > > + items: > > + - const: google,lazor-rev9-sku0 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook Spin 513 with LTE (newest rev) > > items: > > - const: google,lazor-sku0 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9) > > + items: > > + - const: google,lazor-rev9-sku10 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev) > > + items: > > + - const: google,lazor-sku10 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook 511 (rev4 - rev8) > > items: > > - const: google,lazor-rev4-sku4 > > @@ -526,6 +551,11 @@ properties: > > - const: google,lazor-rev8-sku4 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook 511 Parade bridge chip (rev9) > > + items: > > + - const: google,lazor-rev9-sku4 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook 511 (newest rev) > > items: > > - const: google,lazor-sku4 > > @@ -545,11 +575,36 @@ properties: > > - const: google,lazor-rev8-sku6 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen (rev9) > > + items: > > + - const: google,lazor-rev9-sku6 > > + - const: qcom,sc7180 > > + > > - description: Acer Chromebook 511 without Touchscreen (newest rev) > > items: > > - const: google,lazor-sku6 > > - const: qcom,sc7180 > > > > + - description: Acer Chromebook 511 Parade bridge chip no-esim (rev9) > > + items: > > + - const: google,lazor-rev9-sku15 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook 511 no-esim (newest rev) > > + items: > > + - const: google,lazor-sku15 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook 511 Parade bridge chip without Touchscreen no-esim (rev9) > > + items: > > + - const: google,lazor-rev9-sku18 > > + - const: qcom,sc7180 > > + > > + - description: Acer Chromebook 511 without Touchscreen no-esim (newest rev) > > + items: > > + - const: google,lazor-sku18 > > All of these entries (existing and new) should be just one entry with: > - enum: > - .... > - .... > - const: qcom,sc7180 I believe we've had this discussion before. At least twice. Here's a link to the last time you said "Ah, OK, I guess this is fine". https://lore.kernel.org/r/d3d4d90b-85b5-5ad9-78e6-5a074c21af4f@xxxxxxxxxx
