On Mon, 14 Aug 2023 at 22:00, Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> wrote: > > > > On 7/28/2023 7:04 PM, Dmitry Baryshkov wrote: > > On 28/07/2023 16:23, Vikash Garodia wrote: > >> Here is the implementation of v4l2 wrapper functions for all > >> v4l2 IOCTLs. > > > > Please do not describe the patch. "Here is..." , "This patch...", "This > > commit..." is a bad style. Please describe _why_ you are doing this. In > > other words, what is the purpose of adding such wrappers. Please rewrite > > your commit messages describing the reasons, not the patch contents. > > > Sure, Will add descriptive commit text explaining the need of changes, in > next version. Please restructure your commits into functional chunks rather than just committing file after file. This way you will have logical commit messages for all your changes. > >> > >> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> > >> Signed-off-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> > >> --- > >> .../platform/qcom/iris/vidc/inc/msm_vidc_v4l2.h | 77 ++ > >> .../platform/qcom/iris/vidc/src/msm_vidc_v4l2.c | 953 > >> +++++++++++++++++++++ > >> 2 files changed, 1030 insertions(+) > >> create mode 100644 > >> drivers/media/platform/qcom/iris/vidc/inc/msm_vidc_v4l2.h > >> create mode 100644 > >> drivers/media/platform/qcom/iris/vidc/src/msm_vidc_v4l2.c -- With best wishes Dmitry
