On 7/28/2023 10:51 PM, Konrad Dybcio wrote: > On 28.07.2023 15:23, Vikash Garodia wrote: >> This implements decoder functionalities of the driver. >> >> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> >> Signed-off-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> >> --- > I see a whole bunch of shifts, ANDs, etc. > > Please convert that to GENMASK + FIELD_PREP/FIELD_GET > Sure, will explore more on this. > Konrad