On 7/28/2023 9:28 PM, Bryan O'Donoghue wrote: > On 28/07/2023 14:23, Vikash Garodia wrote: >> + rc = hfi_packet_sys_intraframe_powercollapse(core, core->packet, >> + core->packet_size, enable); >> + if (rc) >> + return rc; > > I'm 99.9999999999 % sure this is misnamed. > > "Inter" means in-between two things. > "Intra" means inside of one thing. > > So "intraframe" means inside of one frame "interframe" would mean power > collapsing in-between two frames, which is what I think this does. > > And I'd still rather be adding inter-frame power-collapse to as many > different versions of the existing silicon and new silicon as opposed to > segregating it off in a new driver. > > I'm assuming that more than sm8550 supports it since @ the end of the day > this is a firmware feature to power-collapse during an active session when > we aren't busy. > You are actually 100% correct here, it is indeed inter frame power collapse, Will rename this api with hfi_packet_sys_interframe_powercollapse Thanks, Dikshita > --- > bod
