On Mon, Aug 14, 2023 at 01:08:39PM +0800, Baolu Lu wrote: > > @@ -989,6 +989,12 @@ static int tegra_smmu_def_domain_type(struct device *dev) > > } > > static const struct iommu_ops tegra_smmu_ops = { > > + /* > > + * FIXME: For now we want to run all translation in IDENTITY mode, > > + * better would be to have a def_domain_type op do this for just the > > + * quirky device. > > + */ > > + .default_domain = &tegra_smmu_identity_domain, > > tegra_smmu_def_domain_type() has already forced the core to use > ops->identity_domain, why do we still need ops->default_domain? This looks like it is just some cruft from an earlier version that did not have tegra_smmu_def_domain_type(), I deleted it Thanks, Jason