On 8/9/23 06:44, Ruan Jinjie wrote: > The NULL initialization of the pointer assigned by kzalloc() first is > not necessary, because if the kzalloc() failed, the pointer will be > assigned NULL, otherwise it works as usual. so remove it. > > Signed-off-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx> > --- > drivers/gpu/drm/virtio/virtgpu_submit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_submit.c b/drivers/gpu/drm/virtio/virtgpu_submit.c > index 3c00135ead45..82563dbec2ab 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_submit.c > +++ b/drivers/gpu/drm/virtio/virtgpu_submit.c > @@ -274,7 +274,7 @@ static int virtio_gpu_fence_event_create(struct drm_device *dev, > struct virtio_gpu_fence *fence, > u32 ring_idx) > { > - struct virtio_gpu_fence_event *e = NULL; > + struct virtio_gpu_fence_event *e; > int ret; > > e = kzalloc(sizeof(*e), GFP_KERNEL); Reviewed-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> -- Best regards, Dmitry