On 11.08.2023 18:09, Rob Clark wrote:
> On Fri, Aug 11, 2023 at 9:05 AM Rob Clark <robdclark@xxxxxxxxx> wrote:
>>
>> From: Rob Clark <robdclark@xxxxxxxxxxxx>
>>
>> There isn't actually a a690_gmu.bin. But it appears that the normal
>> a660_gmu.bin works fine. Normally all the devices within a sub-
>> generation (or "family") will use the same fw, and a690 is in the a660
>> family.
>>
>
> possibly this could be considered as:
>
> Fixes: 5e7665b5e484 ("drm/msm/adreno: Add Adreno A690 support")
For a lack of a better response, "meh"
Other than that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Perhaps we could take this further and do something like
if (failed to load gmu fw)
try loading "gmu.bin"
Konrad
>
>> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
>> ---
>> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
>> index 1ed270dae148..756a9cfe1cbf 100644
>> --- a/drivers/gpu/drm/msm/adreno/adreno_device.c
>> +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
>> @@ -478,7 +478,7 @@ static const struct adreno_info gpulist[] = {
>> .family = ADRENO_6XX_GEN4,
>> .fw = {
>> [ADRENO_FW_SQE] = "a660_sqe.fw",
>> - [ADRENO_FW_GMU] = "a690_gmu.bin",
>> + [ADRENO_FW_GMU] = "a660_gmu.bin",
>> },
>> .gmem = SZ_4M,
>> .inactive_period = DRM_MSM_INACTIVE_PERIOD,
>> --
>> 2.41.0
>>
