On 08/31/2015 09:55 PM, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > >> The rx and tx channel info are laid out in memory next to each >> other, and there are two types of channel info structures, byte >> based and word based. We have 4 pointers to these info >> structures, when we really only need two to point to the >> different types of structures. Encapsulate the byte based and word >> based tx/rx structures in a "full channel" structure that >> describes the layout of memory and reduces the number of pointers >> in the smd channel structure by two. >> > Saving the extra pointer doesn't feel like worth the change, but > representing the pair of info structs as one sounds like a reasonable > cleanup. Agreed. > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> >> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> >> --- >> drivers/soc/qcom/smd.c | 61 +++++++++++++++++++++++++++----------------------- >> 1 file changed, 33 insertions(+), 28 deletions(-) >> >> diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c >> index edd9d9a37238..c16547b85e05 100644 >> --- a/drivers/soc/qcom/smd.c >> +++ b/drivers/soc/qcom/smd.c >> @@ -65,7 +65,9 @@ >> */ >> >> struct smd_channel_info; >> +struct smd_full_channel_info; > I would have called this "smd_channel_info_pair"... Sure I'll make the change and add your Reviewed-by. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
