On Aug 03 2023 14:34, Pavan Kondeti wrote: > On Thu, Aug 03, 2023 at 01:23:16AM -0700, Guru Das Srinagesh wrote: > > This script runs get_maintainer.py on a given patch file and adds its > > output to the patch file in place with the appropriate email headers > > "To: " or "Cc: " as the case may be. These new headers are added after > > the "From: " line in the patch. > > > > Currently, for a single patch, maintainers are added as "To: ", mailing > > lists and all other roles are addded as "Cc: ". > > > > For a series of patches, however, a set-union scheme is employed in > > order to solve the all-too-common problem of sending subsets of a patch > > series to some lists, which results in important pieces of context such > > as the cover letter being dropped. This scheme is as follows: > > - Create set-union of all mailing lists corresponding to all patches and > > add this to all patches as "Cc: " > > - Create set-union of all other roles corresponding to all patches and > > add this to all patches as "Cc: " > > - Create set-union of all maintainers from all patches and use this to > > do the following per patch: > > - add only that specific patch's maintainers as "To: ", and > > - the other maintainers from the other patches as "Cc: " > > > > Thanks. I have tested this logic by running this script on two patches > from different subsystems. It does what it says. Thanks for testing this v2! > > > Please note that patch files that don't have any "Maintainer"s > > explicitly listed in their `get_maintainer.pl` output will not have any > > "To: " entries added to them; developers are expected to manually make > > edits to the added entries in such cases to convert some "Cc: " entries > > to "To: " as desired. > > > > The script is quiet by default (only prints errors) and its verbosity > > can be adjusted via an optional parameter. > > > > Signed-off-by: Guru Das Srinagesh <quic_gurus@xxxxxxxxxxx> > > --- > > scripts/add-maintainer.py | 113 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 113 insertions(+) > > create mode 100755 scripts/add-maintainer.py > > > > Do you need to update MAINTAINERS file? Noted. > [...] > > Few minor issues from my limited testing: > > - It is very unlikely, but for whatever reason if "From:" is present in > the patch (commit description), this script bails out. Pls try running > this script on the current patch. May be you should also look for a > proper email address on this line. > > - When this script is run on a file (get_maintainer.pl allows this), it > throws a runtime warning. may be good to bail out much earlier. > > - When this script runs on a non-existent file, it does not bail out > early. Will fix these. Thank you. Guru Das.
