On Mon 31 Aug 18:41 PDT 2015, Stephen Boyd wrote: > Passing a void ** almost always requires a cast at the call site. > Instead of littering the code with casts every time this function > is called, have qcom_smem_get() return a void pointer to the > location of the smem item. This frees the caller from having to > cast the pointer with the small downside of doing some extra work > to find the item in the case that the caller doesn't care to use > the pointer. > We still need to find the item even if the caller is not interested, to know if we should have returned -ENOENT, so I think it's just a matter of style. I did have the API to return the pointer earlier in development, but it didn't look good and uniform. But in the final piece, that was picked up, I think it makes more sense (and looks better) to do it this way. Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> > --- > > This is on top of the smd and smem big endian support. > How sneaky of you, then we need to approve those patches before we add new consumers of this API... Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
