On Mon, Aug 07, 2023 at 09:35:02PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Add the MDC and MDIO pin functions for ethernet1 on sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index 09ae6e153282..38327aff18b0 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -480,6 +480,22 @@ ethernet0_mdio: ethernet0-mdio-pins { > }; > }; > > + ethernet1_default: ethernet1-default-state { > + ethernet1_mdc: ethernet1-mdc-pins { > + pins = "gpio20"; > + function = "emac1_mdc"; > + drive-strength = <16>; > + bias-pull-up; > + }; > + > + ethernet1_mdio: ethernet1-mdio-pins { > + pins = "gpio21"; > + function = "emac1_mdio"; > + drive-strength = <16>; > + bias-pull-up; > + }; > + }; > + With the whole "EMAC0 MDIO handles the ethernet phy for EMAC1", this doesn't seem to make sense. I don't have all the schematics, but these pins are not connected from what I see.