Hi, On Fri, Aug 4, 2023 at 2:58 AM Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dts > @@ -0,0 +1,40 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Lazor Limozeen board device tree source > + * > + * Copyright 2023 Google LLC. > + */ > + > +/dts-v1/; > + > +#include "sc7180-trogdor.dtsi" > +#include "sc7180-trogdor-parade-ps8640.dtsi" > +#include "sc7180-trogdor-lazor.dtsi" > +#include "sc7180-trogdor-lte-sku.dtsi" > + > +/ { > + model = "Google Lazor Limozeen without Touchscreen (rev10+)"; > + compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180"; > +}; > + > +/delete-node/&ap_ts; > + > +&panel { > + compatible = "edp-panel"; > +}; > + > +&sdhc_2 { > + status = "okay"; > +}; > + > +&alc5682 { > + compatible = "realtek,rt5682s"; > + /delete-property/ VBAT-supply; > + realtek,dmic1-clk-pin = <2>; > + realtek,dmic-clk-rate-hz = <2048000>; > +}; > + > +&sound { > + compatible = "google,sc7180-trogdor"; > + model = "sc7180-rt5682s-max98357a-1mic"; > +}; The sort ordering of the nodes above is still wrong. It should be alphabetical. AKA "alc5682", "panel", "sdhc_2", "sound". Once that's fixed, feel free to include: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>