RE: [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, July 28, 2023 12:24 PM, Konrad Dybcio wrote:
> On 28.07.2023 21:14, Patrick Whewell wrote:
> > Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg
> > didn't update its configuration" error.
> >
> > Signed-off-by: Patrick Whewell
> > <patrick.whewell@xxxxxxxxxxxxxxxxxxxxxxxxx>
> > Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller
> > driver for SM8250")
> > ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> 
> You could also mention that the error is caused by GPLL9 (the one providing
> the highest frequency in the freq table) not being on by default.
> 
> And ultra nit: your s-o-b should go last

I will be sending over v2 shortly with both comments addressed.

> 
> Konrad
> >  drivers/clk/qcom/gcc-sm8250.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/qcom/gcc-sm8250.c
> > b/drivers/clk/qcom/gcc-sm8250.c index b6cf4bc88d4d..d3c75bb55946
> > 100644
> > --- a/drivers/clk/qcom/gcc-sm8250.c
> > +++ b/drivers/clk/qcom/gcc-sm8250.c
> > @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> >  		.name = "gcc_sdcc2_apps_clk_src",
> >  		.parent_data = gcc_parent_data_4,
> >  		.num_parents = ARRAY_SIZE(gcc_parent_data_4),
> > +		.flags = CLK_OPS_PARENT_ENABLE,
> >  		.ops = &clk_rcg2_floor_ops,
> >  	},
> >  };




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux