On Mon, Jul 31, 2023 at 10:15:34AM +0200, Konrad Dybcio wrote: > On 31.07.2023 06:10, Bjorn Andersson wrote: > > From: Chris Lew <clew@xxxxxxxxxxxxxx> > No QUIC email? > That's the author and s-o-b address of the patch. mailmap will help you if you want to reach him. > [...] > > > > +static ssize_t qmp_debugfs_write(struct file *file, const char __user *userstr, > > + size_t len, loff_t *pos) > > +{ > > + struct qmp *qmp = file->private_data; > > + char buf[QMP_MSG_LEN]; > > + int ret; > > + > > + if (!len || len > QMP_MSG_LEN) > >=? Otherwise the last char may be overwritten by the NULL termination > couple lines below > My mind had a '\0' accounted for in len as well, but you're right. Thanks, Bjorn