On 31/07/2023 08:13, Tengfei Fan wrote: > Adjust the position of QCOM_ID_QDU1010, so that there is a coherent > sequence of numbers. > > Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0 Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > --- > include/dt-bindings/arm/qcom,ids.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h > index bcbe9ee2cdaf..977c235ed0d9 100644 > --- a/include/dt-bindings/arm/qcom,ids.h > +++ b/include/dt-bindings/arm/qcom,ids.h > @@ -249,8 +249,8 @@ > #define QCOM_ID_SA8775P 534 > #define QCOM_ID_QRU1000 539 > #define QCOM_ID_QDU1000 545 > -#define QCOM_ID_QDU1010 587 > #define QCOM_ID_IPQ5019 569 I don't think this change is needed. Isn't IPQ5019 going away? Best regards, Krzysztof