On Thu, 27 Jul 2023 at 02:14, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > On 7/26/2023 3:58 PM, Dmitry Baryshkov wrote: > > On Thu, 27 Jul 2023 at 01:30, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > >> > >> > >> > >> On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote: > >>> As we are going to use MDSS data for DPU programming, populate missing > >>> MDSS data. The UBWC 1.0 and no UBWC cases do not require MDSS > >>> programming, so skip them. > >>> > >> > >> Can you pls point me to the downstream references you used for msm8998? > > > > msm-3.18, drivers/video/msm/mdss/mdss_mdp.c > > > > See the function mdss_mdp_hw_rev_caps_init(). It sets has_ubwc for MDP > > 1.07 (msm8996), 1.14 (msm8937) / 1.16 (msm8953) and 3.0 (msm8998). > > > > It sets has_ubwc but I still cannot locate where it says version is 1.0. > Because the 0x58 register reads 0 and not 1 for msm8998. What would be the version then? 0.0 sounds strange. I'm yet to check whether UBWC works on 8996 / 8998. > >> Was that just taken from catalog? If so I would ask for the reference > >> for the catalog too. > >> > >> As per the register the decoder version is 0x0 and not 1. > >> > >> Even encoder version is 0 from what i see and not 1. Thats why a > >> dec_version of UBWC_1_0 is not doing anything i assume. > >> -- With best wishes Dmitry
