On 27/07/2023 09:54, Fenglin Wu wrote: >>>> + - enum: >>>> + - qcom,pm7550ba-vib >>>> + - const: qcom,pm7325b-vib >>>> >>> >>> Yes >> >> I wonder why this approved change turned out to something incorrect in >> your v3 patch... >> > Since I got review comments in the driver change and I was told to > refactor the driver before adding new HW support. I added the HW type > logic in the driver and I was thinking it might be good to add some > generic compatible strings to match with the HW type introduced in the > driver change. > > Anyway, I will update it to what you suggested in next patch. Drivers are not really related to bindings, so whatever HW type you add in driver, is not a reason to change bindings. Reason to change bindings could be for example: because hardware is like that. Best regards, Krzysztof
