On Wed, Jul 26, 2023 at 10:19:01AM -0700, Elliot Berman wrote: > > > On 7/26/2023 3:41 AM, Pavan Kondeti wrote: > > On Mon, Jul 24, 2023 at 03:30:54PM -0700, Elliot Berman wrote: > > > PSCI implements a restart notifier for architectural defined resets. > > > The SYSTEM_RESET2 allows vendor firmware to define additional reset > > > types which could be mapped to the reboot reason. > > > > > > Implement a driver to wire the reboot-mode framework to make vendor > > > SYSTEM_RESET2 calls on reboot. > > > > > > Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx> > > > > Do we need to skip the PSCI call from the existing PSCI restart notifier > > which gets called after your newly introduced callback from reboot mode > > notifier? > > > > No need, the vendor SYSTEM_RESET2 call shouldn't return if the call worked. > >From the documentation of restart handlers, restarting from reboot notifiers may not be correct. Since you hooked it up with reboot-mode driver framework, you may restart the system much early before the actual machine restart kicks in. Pls check. Thanks, Pavan