On Thu, 27 Jul 2023 at 00:21, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote:
>
>
>
> On 5/21/2023 10:10 AM, Dmitry Baryshkov wrote:
> > DPU programming requires knowledge of some of UBWC parameters. This
> > results in duplication of UBWC data between MDSS and DPU drivers. Export
> > the required data from MDSS driver.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > drivers/gpu/drm/msm/msm_mdss.c | 30 +++++++++++++-----------------
> > drivers/gpu/drm/msm/msm_mdss.h | 27 +++++++++++++++++++++++++++
> > 2 files changed, 40 insertions(+), 17 deletions(-)
> > create mode 100644 drivers/gpu/drm/msm/msm_mdss.h
> >
> > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
> > index d1e57099b517..ed836c659688 100644
> > --- a/drivers/gpu/drm/msm/msm_mdss.c
> > +++ b/drivers/gpu/drm/msm/msm_mdss.c
> > @@ -13,7 +13,7 @@
> > #include <linux/pm_runtime.h>
> > #include <linux/reset.h>
> >
> > -#include "msm_drv.h"
> > +#include "msm_mdss.h"
> > #include "msm_kms.h"
> >
> > #define HW_REV 0x0
> > @@ -26,16 +26,6 @@
> >
> > #define MIN_IB_BW 400000000UL /* Min ib vote 400MB */
> >
> > -struct msm_mdss_data {
> > - u32 ubwc_enc_version;
> > - /* can be read from register 0x58 */
> > - u32 ubwc_dec_version;
> > - u32 ubwc_swizzle;
> > - u32 ubwc_static;
> > - u32 highest_bank_bit;
> > - u32 macrotile_mode;
> > -};
> > -
> > struct msm_mdss {
> > struct device *dev;
> >
> > @@ -185,12 +175,6 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss)
> > return 0;
> > }
> >
> > -#define UBWC_1_0 0x10000000
> > -#define UBWC_2_0 0x20000000
> > -#define UBWC_3_0 0x30000000
> > -#define UBWC_4_0 0x40000000
> > -#define UBWC_4_3 0x40030000
> > -
> > static void msm_mdss_setup_ubwc_dec_20(struct msm_mdss *msm_mdss)
> > {
> > const struct msm_mdss_data *data = msm_mdss->mdss_data;
> > @@ -236,6 +220,18 @@ static void msm_mdss_setup_ubwc_dec_40(struct msm_mdss *msm_mdss)
> > }
> > }
> >
> > +const struct msm_mdss_data *msm_mdss_get_mdss_data(struct device *dev)
> > +{
> > + struct msm_mdss *mdss;
> > +
> > + if (!dev)
> > + return ERR_PTR(-EINVAL);
> > +
> > + mdss = dev_get_drvdata(dev);
> > +
> > + return mdss->mdss_data;
> > +}
> > +
> > static int msm_mdss_enable(struct msm_mdss *msm_mdss)
> > {
> > int ret;
> > diff --git a/drivers/gpu/drm/msm/msm_mdss.h b/drivers/gpu/drm/msm/msm_mdss.h
> > new file mode 100644
> > index 000000000000..02bbab42adbc
> > --- /dev/null
> > +++ b/drivers/gpu/drm/msm/msm_mdss.h
> > @@ -0,0 +1,27 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright (c) 2018, The Linux Foundation
> > + */
>
> Fix the copyright year .
No, the copyright year is correct. The data was moved from the c file
(which has this copyright) and there are no copyrightable additions.
>
> Apart from that,
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
--
With best wishes
Dmitry
