On 26.07.2023 19:46, Konrad Dybcio wrote: > On 26.07.2023 19:26, Stephan Gerhold wrote: >> On Wed, Jul 26, 2023 at 07:20:27PM +0200, Konrad Dybcio wrote: >>> On 26.07.2023 19:18, Stephan Gerhold wrote: >>>> On Wed, Jul 26, 2023 at 06:25:44PM +0200, Konrad Dybcio wrote: >>>>> Some buses need additional manual adjustments atop the usual >>>>> calculations. Fill in the missing coefficients. >>>>> >>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >>>> >>>> What about the funny util-fact/vrail-comp on the mas-apps-proc node >>>> downstream? >>> Can't see it neither on msm-5.4 (with the icc API) nor in the 4.19 (msmbus) >>> device tree. >>> >> >> Not sure where to get up-to-date device trees nowadays. The AOSP repo >> I was looking at has this commit where it was added: >> https://android.googlesource.com/kernel/msm-extra/devicetree/+/02f8c342b23c20a5cf967df649814be37a08227c%5E%21/#F0 > Oh right, take a look at this one: > > https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/commit/201df022706e100cef8d28983c6a7b883fcaec5a > > I guess I'll need to update the icc driver then. Moreover, this having vrail-comp = 96, means I'll have to go with the wrecked downstream way of *(100/(percent)) instead of *(percent/100)... I also noticed that sm6125 makes very heavy use of per-node clocks.. Konrad