On 6/26/2023 1:28 AM, Luca Weiss wrote: > Hi Anjelique, > > On Wed Jun 21, 2023 at 8:59 PM CEST, Anjelique Melendez wrote: >> In certain PMICs, LUT pattern and LPG configuration can be stored in SDAM >> modules instead of LUT peripheral. This feature is called PPG. >> >> This change series adds support for PPG. Thanks! > > Thanks for sending this series! > > I've tested this on SDM632 Fairphone 3 and everything appears to work > fine with setting the pattern. Using fbcli from feedbackd[0] the pattern > shows up correctly. > > The only thing missing really is the addition of the pbs node and adding > the nvmem/nvmem-names & qcom,pbs-client to the lpg node in pmi632.dtsi - > something like the patch below. > > Are you planning to include this in the next revision? Otherwise I can > also send a patch for the pmi632.dtsi after this series has landed. > > Tested-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> # sdm632-fairphone-fp3 (pmi632) > > [0] https://source.puri.sm/Librem5/feedbackd > > Regards > Luca > Hi Luca, So sorry for the late response, I missed this message! Thank you for testing! I was not planning to include adding the pbs node or updating lpg node in pmi632.dtsi. If you are able to send a patch for pmi632.dtsi after that would be great! Thanks, Anjelique
