On 7/25/2023 12:35 AM, Elliot Berman wrote:
On 7/20/2023 12:04 AM, Kathiravan T wrote:
On IPQ platforms, to collect the crashdump, we need to just modify the
DLOAD bit in the TCSR register. Current infrastructure, overwrites the
entire regiter value when enabling the crashdump feature, which leads to
crashdump not gets collected. This series introduce the
qcom_scm_io_update_field API to achieve the same.
I don't think you describe patch 2 in the subject line or cover
letter. As best I can tell, Patches 2 and 3 are independent. They're
similar only in that they both depend on patch 1.
Yeah. I missed that part. I'm thinking of dropping the 2nd patch and
send only the patch 1 and patch 3 in the next spin. Once the patch 1 and
the another pinctrl patch which Bjorn's is referring [1] (Hopefully, If
I am not wrong) is landed in linux-next, I can send out the patch 2
separately. Do let me know if this okay.
[1]
https://lore.kernel.org/linux-arm-msm/2d790f7e-b373-f0ee-d978-fb78bc4f1ed1@xxxxxxxxxxx/
Intially this approach is posted by Poovendhan[1], later Mukesh
integrated this patch in his minidump support series[2]. Based on the
current feedback on the minidump series, seems it will take sometime to
get into a good shape, in the meantime these patches doesn't have any
dependency with the minidump series. As discussed with the Mukesh[3],
posting these 3 patches to enable the crashdump on IPQ chipsets.
Since the current version of minidump series is V4, I'm posting this as
a V5. Please let me know if this should be V1.
[1]
https://lore.kernel.org/linux-arm-msm/20230113160012.14893-4-quic_poovendh@xxxxxxxxxxx/
[2]
https://lore.kernel.org/linux-arm-msm/1676990381-18184-3-git-send-email-quic_mojha@xxxxxxxxxxx/
[3]
https://lore.kernel.org/linux-arm-msm/d77f5601-2b08-a7c7-1400-7ab68b8add3a@xxxxxxxxxxx/
Mukesh Ojha (3):
firmware: qcom_scm: provide a read-modify-write function
pinctrl: qcom: Use qcom_scm_io_update_field()
firmware: scm: Modify only the download bits in TCSR register
drivers/firmware/qcom_scm.c | 26 ++++++++++++++++++++++++--
drivers/pinctrl/qcom/pinctrl-msm.c | 12 +++++-------
include/linux/firmware/qcom/qcom_scm.h | 2 ++
3 files changed, 31 insertions(+), 9 deletions(-)
