On 7/22/2023 8:35 AM, Bjorn Andersson wrote:
On Fri, Jul 21, 2023 at 06:47:42PM +0530, Rohit Agarwal wrote:
On 7/21/2023 11:14 AM, Pavan Kondeti wrote:
On Wed, Jul 19, 2023 at 10:52:41AM +0530, Rohit Agarwal wrote:
diff --git a/include/dt-bindings/power/qcom,rpmhpd.h b/include/dt-bindings/power/qcom,rpmhpd.h
[..]
+
+#endif
--
I see the PD performance levels (RPMH_REGULATOR_LEVEL_xxx) are still
coming from qcom-rpmpd.h. Which means Socs with RPMh also need to
include the older header for these definitions along with this newly
created header. something to improve for the clarity sake?
Agreed. I think we can move these to the new header so that the new SoC with
RPMH can completely
move to rpmhpd.h.
Sounds very reasonable, please do that in a follow up patch.
I'm picking this as is.
I have a doubt related to this about sending the patches.
Since I will be moving the regulators level into the same rpmhpd.h
header, we
would need to update all the qcom soc dtsi file changes as well. Also
there is a
remaining dt-bindings patch that update the older rpmhpd bindings to
these new
ones basically the cleanup is remaining.
Shall I create a unified series updating all these in one and tagging
all the the
related maintainers in the CC
OR
should I create separate series where the dt changes are updated first
then the
followup cleanup dt-bindings series?
Thanks,
Rohit.
Thanks,
Bjorn
