The mipi_dsi_device_register_full() returns an ERR_PTR() on failure,
we should use IS_ERR() to check the return value.
By the way, use dev_err_probe instead of dev_err to print the error code.
Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels")
Signed-off-by: Gaosheng Cui <cuigaosheng1@xxxxxxxxxx>
---
drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c b/drivers/gpu/drm/panel/panel-novatek-nt35950.c
index 8b108ac80b55..eaba0b8d4340 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt35950.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt35950.c
@@ -571,9 +571,9 @@ static int nt35950_probe(struct mipi_dsi_device *dsi)
}
nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info);
- if (!nt->dsi[1]) {
- dev_err(dev, "Cannot get secondary DSI node\n");
- return -ENODEV;
+ if (IS_ERR(nt->dsi[1])) {
+ return dev_err_probe(dev, PTR_ERR(nt->dsi[1]),
+ "Cannot get secondary DSI node\n");
}
num_dsis++;
}
--
2.25.1
