Re: [PATCH v3] arm64: dts: qcom: sdm630: Add support for modem remoteproc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.07.2023 13:18, Krzysztof Kozlowski wrote:>>           From schema:
.../Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
    .../arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dtb:
remoteproc@4080000: memory-region: [[45], [46]] is too short
          From schema:
.../Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml

This needs fixes. The binding lists expected memory regions and you do
not have three of them.

Best regards,
Krzysztof


According to driver code, dedicated reserved metadata memory region is optional. If it is not provided, it is allocated by driver itself using dma_alloc_attr() and then passed to modem processor.

I see that MSM8996 and MSM8998 (nearest sdm660 siblings) got their dedicated metadata reserved regions in patchset [1]. SDM660 MSS was not present at that time and I'm not sure if it is needed for this SoC, because downstream device tree for my device does not have this region. I can either do similar trick for sdm630.dtsi, or alternatively maybe we should fix bindings to indicate that metadata region is optional?

I did quick test: added dedicated reserved metadata region, and everything still works fine, it seems, and one DTB check warning was gone.

[1] https://lore.kernel.org/all/20230117085840.32356-1-quic_sibis@xxxxxxxxxxx/

--
Regards,
Alexey Minnekhanov
postmarketOS developer



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux