On 18.07.2023 15:20, Johan Hovold wrote: > On Mon, Jul 17, 2023 at 05:19:10PM +0200, Konrad Dybcio wrote: >> Some clocks need to be always-on, but we don't really do anything >> with them, other than calling enable() once and telling Linux they're >> enabled. >> >> Unregister them to save a couple of bytes and, perhaps more >> importantly, allow for runtime suspend of the clock controller device, >> as CLK_IS_CRITICAL prevents the latter. > > But this doesn't sound right. How can you disable a controller which > still has clocks enabled? > > Shouldn't instead these clocks be modelled properly so that they are > only enabled when actually needed? Hm.. We do have clk_branch2_aon_ops, but something still needs to toggle these clocks. I *think* we could leave a permanent vote in probe() without breaking runtime pm! I'll give it a spin bit later.. Konrad
