Changes since v8: ------------------- - v8 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230717103236.1246771-1-bhupesh.sharma@xxxxxxxxxx/ - Konrad and Stephan pointed that I should define 'tcsr syscon' node for sm6115.dtsi, and use phandle for the same inside the EUD node, which would eventually be used inside the eud driver. Added [PATCH 1/7] and [PATCH 5/7] for the same in this series. - Rebased on latest linux-next/master. Changes since v6/v7: ------------------- - v6 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230517211756.2483552-1-bhupesh.sharma@xxxxxxxxxx/ - Konrad and Krzysztof had different suggestions on how to tackle different SoCs inside the eud driver which require access to secure mode manager register space. While Konrad's suggestion was to use a dt property, other comments suggested using optional platform data for determining the same. Modified [PATCH 2/4] accordingly to use the optional platform data for now. - Added Krzysztof's RB for [PATCH 1/4] and also addressed his review comments received on v5. - Dropped eud cleanup patches (which were sent a v7) as they have been accepted in linux-next. - Rebased on latest linux-next/master. Changes since v5: ---------------- - v5 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230516213308.2432018-1-bhupesh.sharma@xxxxxxxxxx/ - Addressed Mani's comment and added Fixes tag for [PATCH 1/6]. Also collected his Ack for this patch. - Fixed [PATCH 4/6] as per Greg's comments and added a separate patch for identation issues -> [PATCH 3/6]. Changes since v4: ---------------- - v4 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230505064039.1630025-1-bhupesh.sharma@xxxxxxxxxx/ - Addressed Konrad's review comments regarding EUD driver code. - Also collected his R-B for [PATCH 4/5 and 5/5]. - Fixed the dt-bindings as per Krzysztof's comments. Changes since v3: ---------------- - v3 can be viewed here: https://www.spinics.net/lists/linux-arm-msm/msg137025.html - Addressed Konrad's review comments regarding mainly the driver code. Also fixed the .dtsi as per his comments. - Also collected his R-B for [PATCH 1/5]. Changes since v2: ---------------- - v2 can be viewed here: https://www.spinics.net/lists/linux-arm-msm/msg137025.html - Addressed Bjorn and Krzysztof's comments. - Added [PATCH 1/5] which fixes the 'qcom_eud' sysfs path. - Added [PATCH 5/5] to enable EUD for Qualcomm QRB4210-RB2 boards. Changes since v1: ---------------- - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20221231130743.3285664-1-bhupesh.sharma@xxxxxxxxxx - Added Krzysztof in Cc list. - Fixed the following issue reported by kernel test bot: >> ERROR: modpost: "qcom_scm_io_writel" [drivers/usb/misc/qcom_eud.ko] undefined! This series adds the dt-binding and driver support for SM6115 / SM4250 EUD (Embedded USB Debugger) block available on Qualcomm SoCs. It also enables the same for QRB4210-RB2 boards by default (the user still needs to enable the same via sysfs). The EUD is a mini-USB hub implemented on chip to support the USB-based debug and trace capabilities. EUD driver listens to events like USB attach or detach and then informs the USB about these events via ROLE-SWITCH. Bhupesh Sharma (7): dt-bindings: mfd: qcom,tcsr: Add the compatible for SM6115 dt-bindings: soc: qcom: eud: Document vendor-specific 'secure mode' property dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 support usb: misc: eud: Add driver support for SM6115 / SM4250 arm64: dts: qcom: sm6115: Add tcsr syscon node arm64: dts: qcom: sm6115: Add EUD dt node and dwc3 connector arm64: dts: qcom: qrb4210-rb2: Enable EUD debug peripheral .../devicetree/bindings/mfd/qcom,tcsr.yaml | 1 + .../bindings/soc/qcom/qcom,eud.yaml | 9 +++ arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 27 ++++++- arch/arm64/boot/dts/qcom/sm6115.dtsi | 56 ++++++++++++++ drivers/usb/misc/Kconfig | 2 +- drivers/usb/misc/qcom_eud.c | 76 +++++++++++++++++-- 6 files changed, 164 insertions(+), 7 deletions(-) -- 2.38.1
